feat: create client_applications_usage table migration #4521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sjaanus
reviewed
Aug 17, 2023
| ` | ||
| CREATE TABLE IF NOT EXISTS client_applications_usage ( | ||
| app_name VARCHAR(255) REFERENCES client_applications(app_name) ON DELETE CASCADE, | ||
| project VARCHAR(255) REFERENCES projects(id) NOT NULL default 'default', |
There was a problem hiding this comment.
I think we can not put foreign key on this, because we also have *. Same for environment
There was a problem hiding this comment.
Also, can there be instances where default project does not exist. I am not sure, but looks potentially dangerous.
There was a problem hiding this comment.
fair enough - default project and environment are created by our migrations. Good point on the *
There was a problem hiding this comment.
Actually we could preserve the FK, but keep it nullable. And then null means all projects.
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
sjaanus
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates client_applications_usage table