Change request advanced search and filter #4544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-request-advanced-search-and-filter
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kwasniew
commented
Aug 22, 2023
| @@ -9,12 +11,15 @@ const StyledContainer = styled('div')(({ theme }) => ({ | |||
| })); | |||
|
|
|||
| export const AvatarCell = ({ value }: any) => { | |||
| const { searchQuery } = useSearchHighlightContext(); | |||
There was a problem hiding this comment.
added highlighter to all components that were missing it
kwasniew
commented
Aug 22, 2023
| suggestedOption: | ||
| filterOptions[randomRow] ?? `example-${column.filterName}`, | ||
| options[randomRow] ?? `example-${column.filterName}`, |
There was a problem hiding this comment.
we want to suggest from the valid options after pre-processing. E.g. with quotes, with split new line
kwasniew
commented
Aug 22, 2023
| const options = [...new Set(filterOptions)] | ||
| .filter(Boolean) | ||
| .flatMap(item => item.split('\n')) | ||
| .filter(item => !item.includes('"') && !item.includes("'")) |
There was a problem hiding this comment.
if your field value is using quotes (corner case) we filter it out to not mess with the search quotes
kwasniew
commented
Aug 22, 2023
| @@ -61,7 +61,7 @@ export const SearchDescription: VFC<ISearchDescriptionProps> = ({ | |||
| {filter.values.join(',')} | |||
| </StyledCode>{' '} | |||
| in {filter.header}. Options:{' '} | |||
| {filter.options.join(', ')} | |||
| {filter.options.slice(0, 10).join(', ')} | |||
There was a problem hiding this comment.
we don't want to present more than 10 options. E.g. for feature names in change request list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Filtering and searching change requests.
filtering options:
searching options:
Important files
Discussion points