feat: applicaton usage endpoint #4548
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| }); | ||
|
|
||
| const reduceRows = (rows: any[]): IClientApplication[] => { |
There was a problem hiding this comment.
Since we are joining usage table, there are duplicate entries, which we are reducing into usage object.
| const existingApp = acc[row.app_name]; | ||
|
|
||
| if (existingApp) { | ||
| let project = existingApp.usage.find( |
| project: joi.string().allow('').optional(), | ||
| environment: joi.string().allow('').optional(), |
There was a problem hiding this comment.
Is joi still in use? I thought OpenAPI was handling validation now.
There was a problem hiding this comment.
Yes, we have around 63 usages of this kind of validation. If we are creating anything new, we go with OpenAPI, but older endpoints use it.
There was a problem hiding this comment.
But we do have an application-schema.ts. Does this not handle the validation?
There was a problem hiding this comment.
This is used for response, but joi is doing for request.
| (usage) => usage.project === row.project, | ||
| ); | ||
|
|
||
| if (project) { | ||
| project.environments.push(row.environment); | ||
| } else { | ||
| existingApp.usage.push({ | ||
| project: row.project, | ||
| environments: [row.environment], | ||
| }); | ||
| } | ||
| } else { | ||
| const mappedRow = mapRow(row); | ||
| acc[row.app_name] = { | ||
| ...mappedRow, | ||
| usage: | ||
| row.project && row.environment | ||
| ? [ | ||
| { | ||
| project: row.project, | ||
| environments: [row.environment], | ||
| }, | ||
| ] | ||
| : [], | ||
| }; |
There was a problem hiding this comment.
Spent a fair bit of time looking at this function to figure out what it does. Could we simplify it?
There was a problem hiding this comment.
Refactored a little, but cant do much more.
No description provided.