feat: add a setting for toggling requesting additional scopes #4551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
nunogois
reviewed
Aug 23, 2023
Co-authored-by: Nuno Góis <github@nunogois.com>
gardleopard
reviewed
Aug 23, 2023
gardleopard
approved these changes
Aug 24, 2023
| <Grid item md={5}> | ||
| <strong>Request 'groups' Scope</strong> | ||
| <p> | ||
| When enabled Unleash will also request the 'groups' scope as part of the login request. |
nunogois
approved these changes
Aug 25, 2023
daveleek
added a commit
that referenced
this pull request
Aug 25, 2023
Adds a setting to OIDC SSO configuration that controls whether or not additional scopes are to be requested during login <img width="944" alt="Skjermbilde 2023-08-24 kl 09 00 54" src="https://github.com/Unleash/unleash/assets/707867/8cf06fb4-aefd-48cd-b09b-99d35a2a10ed"> --------- Co-authored-by: Nuno Góis <github@nunogois.com>
daveleek
added a commit
that referenced
this pull request
Aug 25, 2023
…#4573) Adds a setting to OIDC SSO configuration that controls whether or not additional scopes are to be requested during login <img width="944" alt="Skjermbilde 2023-08-24 kl 09 00 54" src="https://github.com/Unleash/unleash/assets/707867/8cf06fb4-aefd-48cd-b09b-99d35a2a10ed"> --------- <!-- Thanks for creating a PR! To make it easier for reviewers and everyone else to understand what your changes relate to, please add some relevant content to the headings below. Feel free to ignore or delete sections that you don't think are relevant. Thank you! ❤️ --> ## About the changes <!-- Describe the changes introduced. What are they and why are they being introduced? Feel free to also add screenshots or steps to view the changes if they're visual. --> <!-- Does it close an issue? Multiple? --> Closes # <!-- (For internal contributors): Does it relate to an issue on public roadmap? --> <!-- Relates to [roadmap](https://github.com/orgs/Unleash/projects/10) item: # --> ### Important files <!-- PRs can contain a lot of changes, but not all changes are equally important. Where should a reviewer start looking to get an overview of the changes? Are any files particularly important? --> ## Discussion points <!-- Anything about the PR you'd like to discuss before it gets merged? Got any questions or doubts? --> Co-authored-by: Nuno Góis <github@nunogois.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a setting to OIDC SSO configuration that controls whether or not additional scopes are to be requested during login