fix: do not allow creation/update of feature toggle with invalid strategy name #4555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sjaanus
commented
Aug 23, 2023
| @@ -14,6 +14,30 @@ | |||
| "type": "string" | |||
| } | |||
| ] | |||
| }, | |||
| { | |||
| "name": "flexibleRollout", | |||
There was a problem hiding this comment.
Also add flexibleRollout for our e2e tests
sjaanus
commented
Aug 23, 2023
| @@ -225,24 +231,24 @@ class FeatureToggleService { | |||
|
|
|||
| validateUpdatedProperties( | |||
| { featureName, projectId }: IFeatureContext, | |||
| strategy: IFeatureStrategy, | |||
| existingStrategy: IFeatureStrategy, | |||
There was a problem hiding this comment.
Refactoring to make it more clear
sjaanus
commented
Aug 23, 2023
| this.validateUpdatedProperties(context, existingStrategy); | ||
| await this.validateStrategyType(updates.name); |
There was a problem hiding this comment.
Validate for updating
sjaanus
commented
Aug 23, 2023
| @@ -502,6 +516,7 @@ class FeatureToggleService { | |||
| const { featureName, projectId, environment } = context; | |||
| await this.validateFeatureBelongsToProject(context); | |||
|
|
|||
| await this.validateStrategyType(strategyConfig.name); | |||
There was a problem hiding this comment.
Validate for creation
sjaanus
changed the title
kwasniew
reviewed
Aug 23, 2023
| strategyName: string | undefined, | ||
| ): Promise<void> { | ||
| if (strategyName !== undefined) { | ||
| await this.strategyStore.get(strategyName); |
There was a problem hiding this comment.
is it depending on store throwing an error?
I'd rather call exists method on store and explicitly throw and error BadDataError. Those DB errors get propagated to the UI which is not nice. It's better to wrap it into some HTTP friendly error
kwasniew
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restrict creation/update on strategies with invalid strategy type.