feat: import service validate duplicates #4558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kwasniew
commented
Aug 23, 2023
| @@ -144,6 +145,7 @@ export default class ExportImportService { | |||
| async validate( | |||
| dto: ImportTogglesSchema, | |||
| user: User, | |||
| mode = 'regular' as Mode, | |||
There was a problem hiding this comment.
enterprise can pass change-request mode
kwasniew
commented
Aug 23, 2023
| unsupportedStrategies, | ||
| unsupportedContextFields || [], | ||
| [], | ||
| const errors = ImportValidationMessages.compileErrors({ |
There was a problem hiding this comment.
introduced object to make it more manageable
kwasniew
commented
Aug 23, 2023
| await this.createOrUpdateToggles(cleanedDto, user); | ||
| } | ||
|
|
||
| async importToggleLevelInfo( |
There was a problem hiding this comment.
used by enterprise
kwasniew
commented
Aug 23, 2023
| async import(dto: ImportTogglesSchema, user: User): Promise<void> { | ||
| const cleanedDto = await this.cleanData(dto); | ||
|
|
||
| async importVerify( |
There was a problem hiding this comment.
used by enterprise
kwasniew
commented
Aug 23, 2023
| @@ -46,35 +59,28 @@ export class ImportValidationMessages { | |||
| ), | |||
| }); | |||
| } | |||
| if (segments.length > 0) { | |||
There was a problem hiding this comment.
moved to enterprise
kwasniew
commented
Aug 23, 2023
| }); | ||
| } | ||
| if (changeRequestExists) { |
There was a problem hiding this comment.
moved to enterprise
sjaanus
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Validate if we have duplicate feature in import.
Also preparing for duplication removal in the enterprise service by extracting shared methods.
Important files
Discussion points