fix: group roles assumption, refactor group types #4576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
nunogois
commented
Aug 25, 2023
| cy.get("td span:contains('2 roles')").should('have.length', 1); | ||
| }); | ||
| // TODO: This works locally but not on GH actions, I assume because of the way we (don't) handle feature flagging for Cypress tests in GH actions. | ||
| // This should be uncommented again once we remove the multipleRoles flag or if we find a better solution in the meantime. |
There was a problem hiding this comment.
I can reproduce the error locally, but unsure why it's happening. I'm receiving users without roles
gastonfournier
requested changes
Sep 1, 2023
nunogois
force-pushed
the
refactor-group-id-required
branch
from
c4c404b
to
6b46924
Compare
nunogois
commented
Sep 7, 2023
| : access?.roles.find( | ||
| ({ id }) => id === row.entity.roleId | ||
| )?.name | ||
| : 'No Roles!', |
There was a problem hiding this comment.
@gastonfournier I think this changed slipped by me and I'm curious: What was the reason for it? Do we expect any reason why roles can be falsy?
There was a problem hiding this comment.
Oh, I think this was accidental when trying to figure out why the tests were failing, I added this to try to see if this was the issue in cypress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin, should help with cleaning up #4512 and respective schema changes.