chore: Remove duplicated tags #4580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
thomasheartman
added a commit
that referenced
this pull request
Sep 1, 2023
This change sorts the tags in the tags file. This makes it easier to find tags in the file. #4580 already introduced a test to check that we have no duplicate tags, so this isn't as necessary anymore, but it's still nice to have.
thomasheartman
added a commit
that referenced
this pull request
Sep 1, 2023
This change sorts the tags in the tags file and tests that the list is sorted alphabetically. This makes it easier to find tags in the file. #4580 already introduced a test to check that we have no duplicate tags, so this isn't as necessary anymore, but it's still nice to have. It also removes the previous auto-sorting before exporting. This is to ensure that entries are sorted in the source list. This might seem like a regression, but it makes it easier to spot near-duplicate tags: > Despite having the test that validates there are no duplicates, you can always have Notifications and Notification API by mistake (tags that mean the same but are different). Keeping the list alphabetically sorted might help to prevent this before pushing the change to prod. In this case, we will eventually find out and fix it, so this could be a good reason to have the list sorted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
At #4432 we've introduced the same tags twice which causes issues when generating the api clients.
Closes #2-1350-fix-openapi-duplicated-tags