New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: return 404 when projectid not found #4581

Merged

daveleek merged 3 commits into main from fix/project-api-tokens-return-not-found

Aug 30, 2023

Contributor

daveleek commented Aug 28, 2023

About the changes

Returns Not Found on create and get project api tokens when given a project id that doesn't exist

Discussion points

This is an extra lookup per execution of the endpoint


          chore: return 404 when projectid not found

978ac85

vercel bot commented Aug 28, 2023 •

edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
unleash-docs	⬜️ Ignored (Inspect)	Visit Preview		Aug 29, 2023 6:10am
unleash-monorepo-frontend	⬜️ Ignored (Inspect)	Visit Preview		Aug 29, 2023 6:10am

github-actions bot assigned daveleek

nunogois reviewed

View reviewed changes

src/lib/routes/admin-api/project/api-token.ts Outdated Show resolved Hide resolved


          chore: replace redundant checking with comment

1eec9b6

nunogois approved these changes

View reviewed changes

Member

nunogois left a comment

LGTM. Maybe I would rephrase the comment a bit, but that's just me.
await this.projectService.getProject(projectId); // Validates that the project exists


          chore: improve comment

80af1e1

daveleek merged commit ff346ad into main

9 checks passed

daveleek deleted the fix/project-api-tokens-return-not-found branch

August 30, 2023 08:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment