-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: strategy variant flag removed #4603
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
@@ -1226,7 +1222,7 @@ class FeatureToggleService { | |||
segments: [], | |||
title: strategy.title, | |||
disabled: strategy.disabled, | |||
// FIXME: Should we return sortOrder here, or adjust OpenAPI? | |||
sortOrder: strategy.sortOrder, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixing a test after removing strategyVariant flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Non-blocking comments :)
@@ -267,11 +267,7 @@ export const FeatureEnvironmentVariants = () => { | |||
} | |||
> | |||
<VariantInfoAlert mode="feature" /> | |||
<ConditionallyRender | |||
condition={Boolean(uiConfig?.flags?.strategyVariant)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uiConfig is unused
@@ -11,7 +11,7 @@ let db: ITestDb; | |||
|
|||
beforeAll(async () => { | |||
db = await dbInit('advanced_playground', getLogger, { | |||
experimental: { flags: { strategyVariant: true } }, | |||
experimental: { flags: {} }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this to be explicitly here but empty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, removing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
About the changes
Strategy variants going into GA
Important files
Discussion points