Search suggestion selectable #4610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kwasniew
commented
Sep 5, 2023
| @@ -69,7 +70,8 @@ export const Search = ({ | |||
| containerStyles, | |||
| debounceTime = 200, | |||
| }: ISearchProps) => { | |||
| const ref = useRef<HTMLInputElement>(); | |||
| const searchInputRef = useRef<HTMLInputElement>(null); | |||
There was a problem hiding this comment.
renaming to meaningful distinction as we have 2 refs now in this component
kwasniew
commented
Sep 5, 2023
| ref.current?.blur(); | ||
| if (document.activeElement === searchInputRef.current) { | ||
| searchInputRef.current?.blur(); | ||
| setShowSuggestions(false); |
There was a problem hiding this comment.
previously there was onBlur action, now we need to explicitly hide suggestions
kwasniew
commented
Sep 5, 2023
| } | ||
| }); | ||
| const placeholder = `${customPlaceholder ?? 'Search'} (${hotkey})`; | ||
|
|
||
| useOnClickOutside([searchInputRef, suggestionsRef], () => |
There was a problem hiding this comment.
clicking outside the search input or search suggestions will hide suggestions
kwasniew
commented
Sep 5, 2023
| @@ -116,7 +123,6 @@ export const Search = ({ | |||
| value={value} | |||
| onChange={e => onSearchChange(e.target.value)} | |||
| onFocus={() => setShowSuggestions(true)} | |||
| onBlur={() => setShowSuggestions(false)} | |||
There was a problem hiding this comment.
this was preventing us from selecting text in the search suggestions
Tymek
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
We want search suggestions to be selectable
To achieve that we hide suggestions on click outside search input and suggestions.
Important files
Discussion points