Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent 404 on auth settings hook #4619

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

nunogois
Copy link
Member

@nunogois nunogois commented Sep 6, 2023

Since auth/{auth_type}/settings is an Enterprise route, this prevents 404s when we try to use the hook to fetch auth settings in non-Enterprise instances by using the conditional useEnterpriseSWR hook.

@vercel
Copy link

vercel bot commented Sep 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 11:46am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2023 11:46am

Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! LGTM

@nunogois nunogois merged commit af9756e into main Sep 6, 2023
13 of 15 checks passed
@nunogois nunogois deleted the fix-auth-settings-404 branch September 6, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants