feat: keyboard navigation in search #4651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kwasniew
commented
Sep 11, 2023
| @@ -111,14 +112,15 @@ export const Search = ({ | |||
| } | |||
| ); | |||
| useKeyboardShortcut({ key: 'Escape' }, () => { | |||
| if (document.activeElement === searchInputRef.current) { | |||
| if (searchContainerRef.current?.contains(document.activeElement)) { | |||
There was a problem hiding this comment.
escape anywhere in the search area should hide suggestions
kwasniew
requested review from
thomasheartman,
FredrikOseberg and
andreas-unleash
kwasniew
commented
Sep 11, 2023
| @@ -57,6 +61,10 @@ export const SearchInstructions: VFC<ISearchInstructionsProps> = ({ | |||
| condition={filter.options.length > 0} | |||
| show={ | |||
| <StyledCode | |||
| tabIndex={0} | |||
There was a problem hiding this comment.
previously we only supported clicks, now we support on enter when tab index is selected
kwasniew
commented
Sep 11, 2023
| ).toBeInTheDocument(); | ||
|
|
||
| screen.getByText(/Title A/i).click(); | ||
| expect(recordedSuggestion).toBe('Title A'); |
There was a problem hiding this comment.
previously undefined from filters was added
kwasniew
commented
Sep 11, 2023
| ? '' | ||
| : filters.map( | ||
| filter => `${filter.name}:${filter.suggestedOption}` | ||
| )[0]; |
There was a problem hiding this comment.
select index only when filters are present
kwasniew
commented
Sep 11, 2023
| filter => `${filter.name}:${filter.suggestedOption}` | ||
| )[0]; | ||
|
|
||
| const onFilter = (suggestion: string) => { |
There was a problem hiding this comment.
extracted existing methods since we use them in click and key down handlers
kwasniew
commented
Sep 11, 2023
| @@ -0,0 +1,31 @@ | |||
| import { useEffect } from 'react'; | |||
|
|
|||
| export const useOnBlur = ( | |||
There was a problem hiding this comment.
reusable hook for navigation away from the element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Important files
Discussion points
For now the elements we tab between are spans even though button would be more correct. Buttons add too many styles that we'd need to remove.