feat: variant with number payload #4654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kwasniew
reviewed
Sep 11, 2023
| @@ -19,6 +19,7 @@ import useUnleashContext from 'hooks/api/getters/useUnleashContext/useUnleashCon | |||
| import { WeightType } from 'constants/variantTypes'; | |||
| import { IFeatureVariantEdit } from '../EnvironmentVariantsModal'; | |||
| import { Delete } from '@mui/icons-material'; | |||
| import useUiConfig from '../../../../../../../hooks/api/getters/useUiConfig/useUiConfig'; | |||
kwasniew
reviewed
Sep 11, 2023
| @@ -195,6 +197,16 @@ export const VariantForm = ({ | |||
|
|
|||
| const [errors, setErrors] = useState<IVariantFormErrors>({}); | |||
|
|
|||
| const shouldAddTypeNumberToOptions = Boolean( | |||
There was a problem hiding this comment.
I'd call it after flag: const variantTypeNumber
kwasniew
reviewed
Sep 11, 2023
| uiConfig.flags.variantTypeNumber | ||
| ); | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
I'm assuming it's because the flag hasn't loaded yet, correct?
There was a problem hiding this comment.
payloadOptions is defined before the component - we need to load the flag and determine whether to add the option to the list
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
kwasniew
approved these changes
Sep 11, 2023
|
If you'd like to write automated tests for variants I added some in StrategyVariants.test.tsx |
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
numberas possible payload type for variant.Adds a flag to enable the feature
Updates all relevant models and schemas
Adds the option to the UI
Closes: # 1-1357