fix: validation for variant payload number type #4671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
andreas-unleash
changed the title
kwasniew
reviewed
Sep 12, 2023
| @@ -293,7 +293,7 @@ export const VariantForm = ({ | |||
| JSON.parse(payload.value); | |||
| } | |||
| if (variantTypeNumber && payload.type === 'number') { | |||
| Number(payload.value); | |||
| return !isNaN(Number(payload.value)); | |||
There was a problem hiding this comment.
it shouldn't matter here but in general it's safer to use Number.isNaN over global isNaN
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
kwasniew
approved these changes
Sep 12, 2023
ivarconr
reviewed
Sep 12, 2023
| @@ -262,7 +262,7 @@ export const VariantForm = ({ | |||
|
|
|||
| const validatePayload = (payload: IPayload) => { | |||
| if (!isValidPayload(payload)) { | |||
| setError(ErrorField.PAYLOAD, 'Invalid JSON.'); | |||
| setError(ErrorField.PAYLOAD, 'Invalid value.'); | |||
There was a problem hiding this comment.
Can we use the payload.type to specify "Invalid JSON" or "Invalid Number"
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds validation to number type for variants