feat: Add active users statistics to metrics #4674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
ivarconr
reviewed
Sep 15, 2023
|
Performance: Average over 100 runs, all stats endpoint queries. I didn't see any excessive memory use. |
Tymek
force-pushed
the
feat/prometheus-active-users
branch
from
d729f61
to
764dd15
Compare
ivarconr
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
getActiveUsersis using multiple stores, so it is refactored into read-modelfeaturesto co-locate related codeCloses https://linear.app/unleash/issue/UNL-230/active-users-prometheus
Important files
src/lib/features/instance-stats/getActiveUsers.tsDiscussion points
getActiveUsersis coded less class-based then previous similar read-models. In one file instead of 3 (read-model interface, fake read model, sql read model). I find types and functions way more readable, but I'm ready to refactor it to interfaces and classes if consistency is more important.