Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: dora cleanup #4676

Merged
merged 10 commits into from
Sep 13, 2023
Merged

chore: dora cleanup #4676

merged 10 commits into from
Sep 13, 2023

Conversation

FredrikOseberg
Copy link
Contributor

This PR adds:

  • Generated types for useProjectDoraMetrics
  • Mobile enhancements
  • Tooltips

@vercel
Copy link

vercel bot commented Sep 13, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2023 1:31pm
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2023 1:31pm

thomasheartman
thomasheartman approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed the generated code, but I'm assuming that's good. With the exception of a link text that I think can be improved, this looks good to me 😄 So I'll slap an approve on it and trust that you handle the link text before merging 🚀

...src/component/project/Project/ProjectDoraMetrics/ProjectDoraFeedback/ProjectDoraFeedback.tsx Outdated Show resolved Hide resolved
@FredrikOseberg @thomasheartman
Update frontend/src/component/project/Project/ProjectDoraMetrics/Proj…
0ca4e43 
…ectDoraFeedback/ProjectDoraFeedback.tsx

Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
@FredrikOseberg FredrikOseberg merged commit 78273e4 into main Sep 13, 2023
10 of 15 checks passed
@FredrikOseberg FredrikOseberg deleted the fix/set-correct-email branch September 13, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasheartman thomasheartman thomasheartman approved these changes

Assignees

@FredrikOseberg FredrikOseberg

Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FredrikOseberg @thomasheartman