fix: Integrations quality updates #4677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Tymek
commented
Sep 13, 2023
Comment on lines
+332
to
+334
| const mediaSrc = process.env.CSP_ALLOWED_MEDIA?.split(',') || []; | ||
| const objectSrc = process.env.CSP_ALLOWED_OBJECT?.split(',') || []; | ||
| const frameSrc = process.env.CSP_ALLOWED_FRAME?.split(',') || []; |
There was a problem hiding this comment.
Up until now this was derived from "default CSP". If someone depended on default CSP to embed frames/objects/media this has a potential to break things.
There was a problem hiding this comment.
It makes sense to support all, but I really struggle to see the value of custom values here.
ivarconr
approved these changes
Sep 14, 2023
thomasheartman
approved these changes
Sep 14, 2023
| @@ -21,6 +21,8 @@ import type { AddonSchema } from 'openapi'; | |||
| import useAddons from 'hooks/api/getters/useAddons/useAddons'; | |||
| import useToast from 'hooks/useToast'; | |||
| import { formatUnknownError } from 'utils/formatUnknownError'; | |||
| import { Dialogue } from 'component/common/Dialogue/Dialogue'; | |||
| import { event } from 'cypress/types/jquery'; | |||
There was a problem hiding this comment.
Suggested change
| import { event } from 'cypress/types/jquery'; |
| - You can set the environment variable CSP_ALLOWED_SCRIPT to allow new scriptSrc (comma separated list) | ||
| - You can set the environment variable CSP_ALLOWED_IMG to allow new imgSrc (comma separated list) | ||
| - You can set the environment variable CSP_ALLOWED_CONNECT to allow new connectSrc (comma separated list) | ||
| - **additionalCspAllowedDomains** (CspAllowedDomains) - use this when you want to enable security headers but have additional domains you need to allow traffic to you can set the following environment variables: |
There was a problem hiding this comment.
Suggested change
| - **additionalCspAllowedDomains** (CspAllowedDomains) - use this when you want to enable security headers but have additional domains you need to allow traffic to you can set the following environment variables: | |
| - **additionalCspAllowedDomains** (CspAllowedDomains) - use this when you want to enable security headers but have additional domains you need to allow traffic to. You can set the following environment variables: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Fix issues uncovered when reviewing integrations list and form.