Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify flag naming tooltip #4685

Conversation

thomasheartman
Copy link
Contributor

@thomasheartman thomasheartman commented Sep 13, 2023

This PR simplifies the flag naming tooltip considerably. It now only contains an example of a pattern and what it will match. It also updates the link in the form section description to point directly to a regex cheat sheet instead of a general regex reference document.

There's a few reasons for doing this:

  1. The text preceding the input already explains what the pattern does and explains that it is a regex.
  2. The text preceding the input also contains a link to a regex cheat sheet (which is arguably a better place to explain regexes than a tooltip).
  3. The tooltip was very long. While a lot of the information there was useful, it would also be hard to use. Imagine a user checking the tooltip, scrolling all the way down, but accidentally moving the mouse a bit and the tooltip disappearing. They would have to scroll all the way down again. Or maybe they need to remember what it was they just looked at. It would be more useful to have the information on a separate page.
  4. The tooltip is not accessible by keyboard. This means that users who use a keyboard to navigate the UI would not be able to scroll or otherwise navigate the tooltip, potentially leaving them in the dark.

image

@vercel
Copy link

vercel bot commented Sep 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview Sep 13, 2023 1:04pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Sep 13, 2023 1:04pm

@thomasheartman thomasheartman merged commit 7eb0075 into main Sep 14, 2023
17 checks passed
@thomasheartman thomasheartman deleted the 1-1317-make-regex-explainer-popup-scrollable-with-the-keyboard branch September 14, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants