Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🟢 feat: open-source segments 🚀 #4690

Merged
merged 10 commits into from
Sep 19, 2023
Merged

🟢 feat: open-source segments 🚀 #4690

merged 10 commits into from
Sep 19, 2023

Conversation

ivarconr
Copy link
Member

@ivarconr ivarconr commented Sep 13, 2023 •
edited

We love all open-source Unleash users. in 2022 we built the segment capability (v4.13) as an enterprise feature, simplify life for our customers.

Now it is time to contribute it to the world 🌏

@vercel
Copy link

vercel bot commented Sep 13, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ❌ Failed (Inspect) Sep 19, 2023 11:18am
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 11:18am

@thomasheartman
Copy link
Contributor

The CodeQL comment is probably worth paying attention to here. It's nothing new (it's been that way for a while), but it's not been picked up until now. I enabled allErrors a while back because it gives a better user experience in case you have multiple errors to fix (so that you don't need to make a new request for each error you fix), but we could turn it off for sure. Maybe it'd be nice if there was an upper limit 🤔

@thomasheartman
Copy link
Contributor

thomasheartman commented Sep 14, 2023 •
edited

The codeql warning is addressed in #4707

@ivarconr
Copy link
Member Author

The codeql warning is addressed in #4707

I will rebase this branch as soon at it has been merged to main.

@thomasheartman
Copy link
Contributor

@ivarconr The change was merged yesterday, so feel free to proceed whenever you like.

gastonfournier
gastonfournier approved these changes Sep 16, 2023
View reviewed changes
Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

...mentAccordionBody/StrategyDraggableItem/StrategyItem/StrategyExecution/StrategyExecution.tsx Show resolved Hide resolved
...erCell/FeatureStrategyList/StrategyList/StrategyItem/StrategyExecution/StrategyExecution.tsx Show resolved Hide resolved
src/server-dev.ts Outdated Show resolved Hide resolved
@ivarconr ivarconr enabled auto-merge (squash) September 19, 2023 10:51
@ivarconr ivarconr merged commit 013efac into main Sep 19, 2023
15 of 17 checks passed
@ivarconr ivarconr deleted the feat/open-source-segments branch September 19, 2023 11:24
@ivarconr ivarconr changed the title feat: open-source segments 🚀 🟢 feat: open-source segments 🚀 Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunogois nunogois nunogois left review comments

@thomasheartman thomasheartman thomasheartman left review comments

@gastonfournier gastonfournier gastonfournier approved these changes

@sjaanus sjaanus Awaiting requested review from sjaanus

@FredrikOseberg FredrikOseberg Awaiting requested review from FredrikOseberg

@dgorton dgorton Awaiting requested review from dgorton

Assignees

@ivarconr ivarconr

Labels
None yet
Projects
Issues and PRs
Archived in project
Unleash Public Roadmap 🚀
Status: Q3-2023
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ivarconr @thomasheartman @gastonfournier @sjaanus @nunogois