1-1385: hide display of pattern info behind a flag #4744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the front end would show info about the pattern if it exists, regardless of whether the feature is active or not. The pattern wouldn't be enforced, but it's confusing anyway, so let's hide it.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thomasheartman
force-pushed
the
1-1385-put-all-comparisons-behind-flags
branch
from
ed0085a
to
bf8b720
Compare
kwasniew
approved these changes
Sep 15, 2023
|
Yes! Good catch 😄 I thought the build failed on unused imports? Or at least commits? But maybe that's just the back end? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the front end would show info about the pattern if it
exists, regardless of whether the feature is active or not. The
pattern wouldn't be enforced, but it's confusing anyway, so let's hide
it.