fix: sort toggleNames before updating last seen #4747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
sjaanus
approved these changes
Sep 15, 2023
andreas-unleash
added a commit
that referenced
this pull request
Sep 15, 2023
Seems like when 2 pods are trying to POST lastSeen metrics, the db gets into a deadlock state. This is an attempt to fix the deadlock by sorting the toggleNames before the update. The hypothesis is that sorted toggle names will reduce the chance of working on the same row at the same exact time Closes # [1-1382](https://linear.app/unleash/issue/1-1382/order-data-before-updating-the-lastseen-to-reduce-change-of-deadlock) Signed-off-by: andreas-unleash <andreas@getunleash.ai> (cherry picked from commit 76a834c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like when 2 pods are trying to POST lastSeen metrics, the db gets into a deadlock state.
This is an attempt to fix the deadlock by sorting the toggleNames before the update.
The hypothesis is that sorted toggle names will reduce the chance of working on the same row at the same exact time
Closes # 1-1382