feat: implement optional json payload and template #4752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
sjaanus
reviewed
Sep 15, 2023
...grations/IntegrationForm/IntegrationParameters/IntegrationParameter/IntegrationParameter.tsx
Outdated
Show resolved
Hide resolved
nunogois
reviewed
Sep 18, 2023
nunogois
reviewed
Sep 18, 2023
nunogois
reviewed
Sep 18, 2023
nunogois
reviewed
Sep 18, 2023
...IntegrationForm/IntegrationParameters/IntegrationParameter/IntegrationParameterTextField.tsx
Outdated
Show resolved
Hide resolved
nunogois
reviewed
Sep 18, 2023
...grations/IntegrationForm/IntegrationParameters/IntegrationParameter/IntegrationParameter.tsx
Outdated
Show resolved
Hide resolved
nunogois
reviewed
Sep 18, 2023
...onForm/IntegrationParameters/IntegrationParameter/IntegrationParameterEnableWithDropdown.tsx
Outdated
Show resolved
Hide resolved
nunogois
reviewed
Sep 18, 2023
...onForm/IntegrationParameters/IntegrationParameter/IntegrationParameterEnableWithDropdown.tsx
Outdated
Show resolved
Hide resolved
nunogois
reviewed
Sep 18, 2023
...onForm/IntegrationParameters/IntegrationParameter/IntegrationParameterEnableWithDropdown.tsx
Outdated
Show resolved
Hide resolved
nunogois
reviewed
Sep 18, 2023
...onForm/IntegrationParameters/IntegrationParameter/IntegrationParameterEnableWithDropdown.tsx
Outdated
Show resolved
Hide resolved
nunogois
reviewed
Sep 18, 2023
...onForm/IntegrationParameters/IntegrationParameter/IntegrationParameterEnableWithDropdown.tsx
Outdated
Show resolved
Hide resolved
nunogois
reviewed
Sep 18, 2023
There was a problem hiding this comment.
My general thought is that this feels slightly overkill. If the body template is optional, do we really need the dropdown that shows/hides it? Because it feels like we could just leave it there, similar to what we do for the webhook addon. We could still hide it behind the feature flag if we wanted.
I feel like this would simplify this PR and feature drastically.
In the other hand, if we really want this dropdown visibility behavior, perhaps it should be a different field type, other than textfield?
Other than that this feels fine, but I would still like us to think a bit about this before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Adds optional support for specifying JSON templates for datadog message payload
Important files
frontend/src/component/integrations/IntegrationForm/IntegrationParameters/IntegrationParameter/IntegrationParameterEnableWithDropdown.tsx- a new component comprising of a text field and a dropdown menusrc/lib/addons/datadog.ts- Where the integration is taking placeDiscussion points