feat: walking skeleton of private projects #4753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kwasniew
reviewed
Sep 15, 2023
kwasniew
reviewed
Sep 15, 2023
kwasniew
reviewed
Sep 15, 2023
| import { IProjectPermissionStore } from './projectPermissionStoreType'; | ||
| import { IProjectPermissionChecker } from './projectPermissionCheckerType'; | ||
|
|
||
| export class ProjectPermissionChecker implements IProjectPermissionChecker { |
There was a problem hiding this comment.
if we don't have any more code we can use the store directly. You can call the store as read model.
kwasniew
reviewed
Sep 15, 2023
| return found || defaultValue; | ||
| } | ||
|
|
||
| /* eslint-disable @typescript-eslint/explicit-module-boundary-types */ |
kwasniew
reviewed
Sep 15, 2023
| req.checkProjectPermissions = async () => { | ||
| const { user } = req; | ||
|
|
||
| let projectId = |
kwasniew
reviewed
Sep 15, 2023
kwasniew
reviewed
Sep 15, 2023
| flagResolver, | ||
| }: Pick<IUnleashConfig, 'getLogger' | 'flagResolver'>, | ||
| { projectService, accessService }: IUnleashServices, | ||
| ): any => { |
There was a problem hiding this comment.
I wouldn't use any. There's a type for async middleware
kwasniew
reviewed
Sep 15, 2023
src/lib/features/project-permissions/projectPermissionMiddleware.ts
Outdated
Show resolved
Hide resolved
kwasniew
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next steps. Add tests and more capabilities