Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: misc integration-related fixes and improvements #4754

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

nunogois
Copy link
Member

https://linear.app/unleash/issue/2-1401/misc-fixes-and-improvements-related-to-the-new-slack-app-integration

This includes multiple UI-related misc fixes and improvements that are not only related with the new Slack App integration but also integrations in general.

  • Improves the styling in the "how does it work" section;
  • Improves the text in the IntegrationMultiSelectors;
  • Switches "Configure" and "Open" around to match designs;
  • Properly handles click event on IntegrationCardMenu (fix navigation on dialog click);
  • Fixes titles and contents for "enable/disable" and "delete" integration dialogs to match designs;
  • Updates Slack App integration "how does it work" section to better reflect the intended behavior;
  • Removes redundant alerts after previous point;
  • Adds an alert in the old Slack integration configuration warning of its deprecation and suggesting the new Slack App integration instead;
  • Fixes typos;
  • Slight refactors;

image

Co-authored by @nicolaesocaciu

@vercel
Copy link

vercel bot commented Sep 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview Sep 15, 2023 0:24am
1 Ignored Deployment
Name Status Preview Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Sep 15, 2023 0:24am

Copy link
Contributor

@nicolaesocaciu nicolaesocaciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nunogois nunogois merged commit 055cf15 into main Sep 15, 2023
17 checks passed
@nunogois nunogois deleted the fix-misc-integration-related-fixes branch September 15, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants