Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simplify channels logic in slack app integration #4756

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

nunogois
Copy link
Member

@nunogois nunogois commented Sep 15, 2023

https://linear.app/unleash/issue/2-1393/drop-the-always-post-to-default-channels-field

This drops the "Always post to default channels" field in the Slack App integration in favor of always posting to the configured channels. This should simplify the configuration of this integration.

Here's a breakdown of the logic with this change:

  • Always post to the configured Slack channels, regardless of tags;
  • Tags are still respected. E.g. if we have a configured channel "channel-1" and a tag for "channel-2", then we post to both channels;
  • As channels are optional, if you would like to skip default channels for certain events and handle everything through tags, you can just create a new configuration without any default channels;

This also updates the labels and changes the tests to better reflect the intended behavior.

image

@vercel
Copy link

vercel bot commented Sep 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview Sep 15, 2023 2:01pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Sep 15, 2023 2:01pm

Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nunogois nunogois merged commit 1dcb33d into main Sep 18, 2023
17 checks passed
@nunogois nunogois deleted the fix-slack-app-simplify-channels-logic branch September 18, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants