feat: simpler integration filters #4766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
nunogois
force-pushed
the
feat-simpler-integration-filters
branch
from
2a79478
to
32f2dad
Compare
| required, | ||
| }) => { | ||
| const renderInput = (params: AutocompleteRenderInputParams) => ( | ||
| <TextField | ||
| {...params} | ||
| error={Boolean(error)} | ||
| helperText={error} | ||
| helperText={error || note} |
There was a problem hiding this comment.
If this is error or note, maybe we should have a single text and another property of type style: 'error' || 'note'?
Personally, I don't like positional parameters having different meanings, and they seem to be mutually exclusive (i.e. when error is undefined you can have a note, when there's an error, it takes precedence over the note, so they can't be rendered together...
There was a problem hiding this comment.
So they're different texts, but the error is "dynamic" in a way. Something can trigger a validation that will set the error state and will display the error.
gastonfournier
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-1407/remove-the-all-checkboxes-from-project-and-environment-filters
Simplifies integration event filters by removing the "ALL" checkboxes from these components. Whether you opted to check the "ALL" checkbox, or not to filter at all, the result is the same - The selected options would act as a filter.
Includes some refactoring and clean up.