Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: feature oriented architecture for feature dependencies #4771

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Sep 19, 2023

About the changes

Since feature toggle controller and service are already too big I decided to split feature dependencies write model into a separate directory. This change only moves things around, no new code is added.

Important files

Discussion points

@vercel
Copy link

vercel bot commented Sep 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2023 9:13am
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2023 9:13am

@kwasniew kwasniew changed the title feat: feature oriented architecture for feature dependencies refactor: feature oriented architecture for feature dependencies Sep 19, 2023
Copy link
Contributor

@FredrikOseberg FredrikOseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwasniew kwasniew merged commit 2843388 into main Sep 19, 2023
11 checks passed
@kwasniew kwasniew deleted the feature-dependencies-feature-directory branch September 19, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants