feat: Persist dependent features #4772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
kwasniew
commented
Sep 19, 2023
| enabled boolean DEFAULT true NOT NULL, | ||
| variants JSONB DEFAULT '[]'::jsonb NOT NULL, | ||
| PRIMARY KEY (parent, child), | ||
| FOREIGN KEY (parent) REFERENCES features (name) ON DELETE RESTRICT, |
There was a problem hiding this comment.
should not be able to delete parent flag when child flags still exist
kwasniew
commented
Sep 19, 2023
| variants JSONB DEFAULT '[]'::jsonb NOT NULL, | ||
| PRIMARY KEY (parent, child), | ||
| FOREIGN KEY (parent) REFERENCES features (name) ON DELETE RESTRICT, | ||
| FOREIGN KEY (child) REFERENCES features (name) ON DELETE CASCADE |
There was a problem hiding this comment.
deleting a child flag should remove the dependency
kwasniew
commented
Sep 19, 2023
| enabled: featureDependency.enabled, | ||
| }; | ||
| if ('variants' in featureDependency) { | ||
| serializableFeatureDependency.variants = JSON.stringify( |
There was a problem hiding this comment.
arrays need to be stringified
kwasniew
commented
Sep 19, 2023
| } | ||
| await this.db('dependent_features') | ||
| .insert(serializableFeatureDependency) | ||
| .onConflict(['parent', 'child']) |
There was a problem hiding this comment.
this gives us upsert semantics
FredrikOseberg
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Persisting dependent features toggles.
parent name, child name, whether parent is enabled or disabled and parent variants that we want to match on
Important files
Discussion points
Database Table Design Decisions:
Both 'parent' and 'child' are set up as foreign key relationships. This allows us to easily display these relationships in the admin user interface and prevents invalid bindings.
While the 'variants' could technically use a foreign key relationship to enforce valid values, it might be overcomplicated. Given that both strategy variants and feature variants are also stored as JSONB, introducing such constraints could be redundant. Moreover, establishing foreign keys to multiple tables presents its challenges. Using JSONB for 'variants' also provides flexibility for potential operator support in the future.
I've decided to address the comprehensive feature-with-dependencies read model/view in a separate PR. This is because introducing it would be a more intricate and potentially riskier change compared to merely saving dependencies.