feat: Client api dependent features #4778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kwasniew
commented
Sep 19, 2023
| @@ -17,20 +17,20 @@ export class DependentFeaturesService { | |||
| } | |||
|
|
|||
| async upsertFeatureDependency( | |||
| parentFeature: string, | |||
| childFeature: string, | |||
There was a problem hiding this comment.
it was a mistake in previous PR
kwasniew
commented
Sep 19, 2023
| .expect('Content-Type', /json/) | ||
| .expect(200) | ||
| .expect((res) => { | ||
| expect(res.body.features[0]).toMatchObject({ |
There was a problem hiding this comment.
this is the basis for the client spec for SDKs
kwasniew
commented
Sep 19, 2023
| @@ -195,6 +201,16 @@ export default class FeatureToggleClientStore | |||
| ) { | |||
| this.addSegmentIdsToStrategy(feature, r); | |||
| } | |||
| if (r.parent && !isAdmin && dependentFeaturesEnabled) { | |||
There was a problem hiding this comment.
we don't want to touch admin API in this PR, only client API to start SDK work
kwasniew
requested review from
FredrikOseberg,
thomasheartman and
andreas-unleash
kwasniew
changed the title
sjaanus
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Client API support for dependent feature toggles.
Important files
Discussion points