-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Unleash Slack App integration #4801
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -62,7 +61,6 @@ const slackAppDefinition: IAddonDefinition = { | |||
FEATURE_STRATEGY_UPDATE, | |||
FEATURE_STRATEGY_ADD, | |||
FEATURE_METADATA_UPDATED, | |||
FEATURE_VARIANTS_UPDATED, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this event is no longer relevant and we should use FEATURE_ENVIRONMENT_VARIANTS_UPDATED
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Couple of tiny nitpicks that you can ignore if you want as it's covered in the parameters section
Co-authored-by: David Leek <david@getunleash.io>
Co-authored-by: David Leek <david@getunleash.io>
d73192b
to
7dc7944
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! A couple minor suggestions, but I'm generally pretty happy 😄
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
https://linear.app/unleash/issue/2-1235/docs-slack-app-integration-documentation
This adds a new reference doc for the new Unleash Slack App integration and marks the previous Slack integration as deprecated.
As a side-effect this PR also fixes an issue where we wouldn't be able to delete tags with special characters.