Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Unleash Slack App integration #4801

Merged
merged 13 commits into from
Sep 22, 2023
Merged

docs: Unleash Slack App integration #4801

merged 13 commits into from
Sep 22, 2023

Conversation

nunogois
Copy link
Member

@nunogois nunogois commented Sep 20, 2023

https://linear.app/unleash/issue/2-1235/docs-slack-app-integration-documentation

This adds a new reference doc for the new Unleash Slack App integration and marks the previous Slack integration as deprecated.

As a side-effect this PR also fixes an issue where we wouldn't be able to delete tags with special characters.

@vercel
Copy link

vercel bot commented Sep 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 10:11pm
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 10:11pm

@@ -62,7 +61,6 @@ const slackAppDefinition: IAddonDefinition = {
FEATURE_STRATEGY_UPDATE,
FEATURE_STRATEGY_ADD,
FEATURE_METADATA_UPDATED,
FEATURE_VARIANTS_UPDATED,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this event is no longer relevant and we should use FEATURE_ENVIRONMENT_VARIANTS_UPDATED instead.

Copy link
Contributor

@daveleek daveleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Couple of tiny nitpicks that you can ignore if you want as it's covered in the parameters section

website/docs/reference/integrations/slack-app.md Outdated Show resolved Hide resolved
website/docs/reference/integrations/slack-app.md Outdated Show resolved Hide resolved
Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! A couple minor suggestions, but I'm generally pretty happy 😄

website/docs/reference/integrations/slack-app.md Outdated Show resolved Hide resolved
website/docs/reference/integrations/slack-app.md Outdated Show resolved Hide resolved
website/docs/reference/integrations/slack-app.md Outdated Show resolved Hide resolved
website/docs/reference/integrations/slack-app.md Outdated Show resolved Hide resolved
website/docs/reference/integrations/slack-app.md Outdated Show resolved Hide resolved
website/docs/reference/integrations/slack-app.md Outdated Show resolved Hide resolved
nunogois and others added 4 commits September 22, 2023 10:33
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants