docs: improve datadog integration docs #4802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nunogois
reviewed
Sep 21, 2023
nunogois
reviewed
Sep 21, 2023
nunogois
reviewed
Sep 21, 2023
nunogois
reviewed
Sep 21, 2023
nunogois
reviewed
Sep 21, 2023
nunogois
reviewed
Sep 21, 2023
nunogois
reviewed
Sep 21, 2023
nunogois
reviewed
Sep 21, 2023
nunogois
reviewed
Sep 21, 2023
Co-authored-by: Nuno Góis <github@nunogois.com>
Co-authored-by: Nuno Góis <github@nunogois.com>
Co-authored-by: Nuno Góis <github@nunogois.com>
Co-authored-by: Nuno Góis <github@nunogois.com>
nunogois
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
LGTM, but I would feel more comfortable having @thomasheartman have a look before we merge this 👍
thomasheartman
approved these changes
Sep 22, 2023
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
|
Thank you @daveleek and @thomasheartman - I'll merge this for now but if you notice anything wrong please let me know and I'll try to quickly fix it in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Improvement to the description of the datadog integration. Adds 2 missing event types, removes an event type that is deprecated and about to be completely removed, adds missing description of extra json headers and source type name, and adds description for the new configuration option for JSON body support