task: Added workflow for calling update-version-action #4805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
chriswk
force-pushed
the
task/addVersionCheckerUpdateAction
branch
from
2736a68
to
c5b8439
Compare
There was a problem hiding this comment.
When is this triggering? If it is with new enterprise releases, then I think this is perfectly fine.
Not sure if we want to keep the -main postfix:
Line 4 in b4742df
gastonfournier
approved these changes
Sep 22, 2023
|
|
||
| on: | ||
| release: | ||
| types: [published] |
There was a problem hiding this comment.
Because of this I believe this will work just fine 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This adds a workflow which automatically triggers on published releases to update the version number for our version checker. In addition it adds a workflow dispatch, in case the version number ended up wrong after an automatic run (for instance when patching an earlier released minor).
Observations
Currently the version checker which receives the update only validates that the new version is also valid semver, it does not however check/verify that we're not suddenly telling it an older version is the newest (improvement available in the version updater repo).