-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: UI stub for adding dependent features #4814
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -32,13 +32,13 @@ afterAll(async () => { | |||
}); | |||
|
|||
const addFeatureDependency = async ( | |||
parentFeature: string, | |||
childFeature: string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was a mistake before
projectId: string; | ||
featureId: string; | ||
} | ||
export const AddDependency: FC<IAddDependencyProps> = ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this entire component will be gone once we have proper design. This is just for manual testing purposes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
onChange={e => setParent(trim(e.target.value))} | ||
/> | ||
<PermissionButton | ||
permission={CREATE_FEATURE_STRATEGY} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a separate permission for this in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one should be CREATE_FEATURE for now since this is what backend is doing. We may consider a new permission in future.
About the changes
UI stub for adding dependent features. Prod impl will differ but I need an easy way to test it for now
Important files
Discussion points