feat: add more events in integrations #4815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nunogois
force-pushed
the
feat-integrations-add-events
branch
from
5527a58
to
5182598
Compare
nunogois
force-pushed
the
feat-integrations-add-events
branch
from
7b4c095
to
4b5cf11
Compare
nunogois
commented
Sep 29, 2023
| value: event, | ||
| label: event, | ||
| })) | ||
| .sort((a, b) => a.label.localeCompare(b.label)); |
There was a problem hiding this comment.
We now have a bunch of events, so it's better if we sort them. Ideally they would be grouped, but maybe that can come in a later PR.
nunogois
commented
Sep 29, 2023
| return type; | ||
| } | ||
| } | ||
| Mustache.escape = (text) => text; |
There was a problem hiding this comment.
Globally disables Mustache escaping so we don't need to specify link variables with {{{link}}}, which would be unintuitive.
nunogois
force-pushed
the
feat-integrations-add-events
branch
from
9b00911
to
3f1b90c
Compare
chriswk
approved these changes
Sep 29, 2023
gastonfournier
approved these changes
Sep 29, 2023
| @@ -171,7 +171,7 @@ export class SegmentService implements ISegmentService { | |||
| await this.eventService.storeEvent({ | |||
| type: SEGMENT_DELETED, | |||
| createdBy: user.email || user.username, | |||
| data: segment, | |||
| preData: segment, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-1253/add-support-for-more-events-in-the-slack-app-integration
Adds support for a lot more events in our integrations. Here is how the full list looks like:
I added the events that I thought were relevant based on my own discretion. Know of any event we should add? Let me know and I'll add it 🙂
For now I only added these events to the new Slack App integration, but we can add them to the other integrations as well since they are now supported.
The event formatter was refactored and changed quite a bit in order to make it easier to maintain and add new events in the future. As a result, events are now posted with different text. Do we consider this a breaking change? If so, I can keep the old event formatter around, create a new one and only use it for the new Slack App integration.
I noticed we don't have good 404 behaviors in the UI for things that are deleted in the meantime, that's why I avoided some links to specific resources (like feature strategies, integration configurations, etc), but we could add them later if we improve this.
This PR also tries to add some consistency to the the way we log events.