Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Doc only should skip build #4820

Merged
merged 3 commits into from
Sep 25, 2023
Merged

chore: Doc only should skip build #4820

merged 3 commits into from
Sep 25, 2023

Conversation

gastonfournier
Copy link
Contributor

About the changes

This fakes the build on docs-only PRs to be able to have a green build.
Touching a doc to validate it works

thomasheartman and others added 2 commits September 21, 2023 15:03
@thomasheartman @gastonfournier
docs: add info on how to troubleshoot and better errors (#4803)
35465de 
This PR adds some troubleshooting information to the website readme and
also makes it so that we get more readable errors in the build logs when
something goes wrong.
@gastonfournier
Add fake build for docs
c32ac1a
@vercel
Copy link

vercel bot commented Sep 22, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Sep 22, 2023 3:31pm
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Visit Preview Sep 22, 2023 3:31pm

@gastonfournier gastonfournier changed the title Doc only should skip build chore: Doc only should skip build Sep 22, 2023
dgorton
dgorton reviewed Sep 24, 2023
View reviewed changes
Copy link
Contributor

@dgorton dgorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't know these build processes. This LGTM, but @thomasheartman has a better chance of spotting any potential issues.

@gastonfournier
Copy link
Contributor Author

I still don't know these build processes. This LGTM, but @thomasheartman has a better chance of spotting any potential issues.

We'll have to try it with some documentation PR. The fact that this PR modifies an action, triggers the real build process. The good news is, that among the 9 successful checks, none is the fake build process. This suggests that it'll trigger if and only if the PR is only changing documentation (actually this is my main concern: to trigger a fake build for docs that modify both code and docs)

@gastonfournier
Copy link
Contributor Author

This could be tested by merging this PR and then rebasing on #4821

ivarconr
ivarconr approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@ivarconr ivarconr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🙂

thomasheartman
thomasheartman approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it a lot 😄

@gastonfournier gastonfournier merged commit eb259a3 into main Sep 25, 2023
9 checks passed
@gastonfournier gastonfournier deleted the doc-only-should-skip-build branch September 25, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgorton dgorton dgorton left review comments

@ivarconr ivarconr ivarconr approved these changes

@thomasheartman thomasheartman thomasheartman approved these changes

Assignees

@gastonfournier gastonfournier

Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gastonfournier @ivarconr @dgorton @thomasheartman