feat: Delete dependency api #4824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kwasniew
commented
Sep 25, 2023
| @@ -45,7 +45,7 @@ export const AddDependency: FC<IAddDependencyProps> = ({ | |||
| onChange={e => setParent(trim(e.target.value))} | |||
| /> | |||
| <PermissionButton | |||
| permission={CREATE_FEATURE} | |||
| permission={UPDATE_FEATURE} | |||
There was a problem hiding this comment.
eventually we'll get a permission for managing dependencies, for now UPDATE_FEATURE is more correct than CREATE_FEATURE
kwasniew
commented
Sep 25, 2023
| openApiService, | ||
| }: DependentFeaturesServices, | ||
| startTransaction: TransactionCreator<UnleashTransaction>, | ||
| ) { | ||
| super(config); | ||
| this.transactionalDependentFeaturesService = | ||
| transactionalDependentFeaturesService; | ||
| this.dependentFeaturesService = dependentFeaturesService; |
There was a problem hiding this comment.
deletion does not have to be transactional as there's only one DB operation involved
chriswk
reviewed
Sep 25, 2023
src/lib/features/dependent-features/dependent-features-service.ts
Outdated
Show resolved
Hide resolved
sjaanus
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
API for deleting feature dependency
Important files
Discussion points