Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: context/segment usage private #4826

Merged
merged 2 commits into from
Sep 25, 2023
Merged

feat: context/segment usage private #4826

merged 2 commits into from
Sep 25, 2023

Conversation

sjaanus
Copy link
Contributor

@sjaanus sjaanus commented Sep 25, 2023

  1. GET single context field strategies will now hide private projects
  2. GET single segment strategies will now hide private projects

This is just reusing the private project checker method, which is heavily tested in enterprise.

@vercel
Copy link

vercel bot commented Sep 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2023 0:22am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Sep 25, 2023 0:22am

@@ -78,11 +78,19 @@ export const SegmentProjectAlert = ({
</StyledUl>
);

if (projectsUsed.length > 1) {
if (projectsUsed.length > 0) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project list should also be shown, when just single project is using it.

@sjaanus sjaanus merged commit 2bf995e into main Sep 25, 2023
18 checks passed
@sjaanus sjaanus deleted the context-private branch September 25, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants