feat: Enforce one dependency #4835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
kwasniew
commented
Sep 26, 2023
| @@ -60,11 +60,6 @@ beforeAll(async () => { | |||
| 'featureY', | |||
| { feature: 'featureX', variants: ['featureXVariant'] }, | |||
| ); | |||
| // depend on parent being disabled | |||
There was a problem hiding this comment.
currently we only support only one dependency in admin. Will bring this back when we support more than one.
Tymek
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Even though our DB supports multiple parent dependencies we want to start experimenting only with one. I'm removing all deps for a feature before creating a new one. Everything is part of the DB Tx started in the controller.
Important files
Discussion points