feat: show available parent dependency options #4837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kwasniew
changed the title
Tymek
approved these changes
Sep 26, 2023
| @@ -15,21 +16,33 @@ const StyledSelect = styled(GeneralSelect)(({ theme }) => ({ | |||
| marginBottom: theme.spacing(1.5), | |||
| })); | |||
|
|
|||
| const REMOVE_DEPENDENCY_OPTION = { | |||
There was a problem hiding this comment.
"remove" option could be more visually distinct
https://mui.com/material-ui/react-select/#labels-and-helper-text
There was a problem hiding this comment.
Will address in the next PR
There was a problem hiding this comment.
I checked this and we use GeneralSelect that unfortunately uses configuration over composition approach. It prevents styling of children. Since this component is temporary and we'll have separate remove dependency widget in future I'll leave it for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Show available parent features and option to remove dependency for a feature:
Full UI test for this component in the next PR
Important files
Discussion points