feat: feature admin API returns dependencies and children #4848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
kwasniew
commented
Sep 27, 2023
| export interface IDependentFeaturesReadModel { | ||
| getChildren(parent: string): Promise<string[]>; | ||
| getParents(child: string): Promise<string[]>; | ||
| getParents(child: string): Promise<IDependency[]>; |
There was a problem hiding this comment.
currently we only need string but I want to have API that will be prepared for the upcoming enhancements (variants, enabled/disabled)
kwasniew
commented
Sep 27, 2023
| return rows.map((row) => ({ | ||
| feature: row.parent, | ||
| enabled: row.enabled, | ||
| variants: row.variants, |
There was a problem hiding this comment.
I was surprised that JSON.parse is not needed here
kwasniew
commented
Sep 27, 2023
| @@ -157,6 +160,8 @@ class FeatureToggleService { | |||
|
|
|||
| private privateProjectChecker: IPrivateProjectChecker; | |||
|
|
|||
| private dependentFeaturesReadModel: IDependentFeaturesReadModel; | |||
There was a problem hiding this comment.
we only depend on read operations in a different module
kwasniew
commented
Sep 27, 2023
| if (projectId) { | ||
| await this.validateFeatureBelongsToProject({ | ||
| featureName, | ||
| projectId, | ||
| }); | ||
| } | ||
|
|
||
| let dependencies: IDependency[] = []; | ||
| let children: string[] = []; | ||
| if (this.flagResolver.isEnabled('dependentFeatures')) { |
There was a problem hiding this comment.
here we do optional enhancement with parent/child information
kwasniew
commented
Sep 27, 2023
| @@ -3394,3 +3395,29 @@ test('should not be allowed to update with invalid strategy type name', async () | |||
| 400, | |||
| ); | |||
| }); | |||
|
|
|||
| test('should list dependencies and children', async () => { | |||
There was a problem hiding this comment.
this shows how this new feature works
kwasniew
commented
Sep 27, 2023
| const child = uuidv4(); | ||
| await app.createFeature(parent, 'default'); | ||
| await app.createFeature(child, 'default'); | ||
| await app.addDependency(child, parent); |
There was a problem hiding this comment.
added this new method since it may come in handy and also code is symmetrical when we do everything with app.doXYZ
kwasniew
requested review from
FredrikOseberg,
sjaanus,
andreas-unleash and
Tymek
kwasniew
changed the title
kwasniew
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Admin feature API returns dependencies and children
Details:
Important files
Discussion points
I decided not to touch the big features_view for now. Reasons: it's already difficult to reason about + for common parents it would generate lots of new rows