feat: display dependencies and parents in project details #4859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kwasniew
commented
Sep 28, 2023
| @@ -44,6 +44,7 @@ export class DependentFeaturesReadModel implements IDependentFeaturesReadModel { | |||
| .where('features.project', result[0].project) | |||
| .andWhere('features.name', '!=', child) | |||
| .andWhere('dependent_features.child', null) | |||
| .andWhere('features.archived_at', null) | |||
There was a problem hiding this comment.
we should not allow depending on archived features
kwasniew
commented
Sep 28, 2023
| @@ -50,6 +52,7 @@ export const AddDependencyDialogue = ({ | |||
| } else { | |||
| await addDependency(featureId, { feature: parent }); | |||
| } | |||
| await refetchFeature(); | |||
There was a problem hiding this comment.
refresh ui after adding/removing dependency
kwasniew
commented
Sep 28, 2023
| @@ -13,4 +13,6 @@ export const emptyFeature: IFeatureToggle = { | |||
| description: '', | |||
| favorite: false, | |||
| impressionData: false, | |||
| dependencies: [], | |||
| children: [], | |||
There was a problem hiding this comment.
default feature should provide default values
kwasniew
commented
Sep 28, 2023
| import { FC, useState } from 'react'; | ||
| import { FlexRow, StyledDetail, StyledLabel, StyledLink } from './StyledRow'; | ||
|
|
||
| export const DependencyRow: FC<{ feature: IFeatureToggle }> = ({ feature }) => { |
There was a problem hiding this comment.
moved this code from a previous location so that everything related to dependencies can be managed in one file
Tymek
approved these changes
Sep 28, 2023
frontend/src/component/feature/Dependencies/AddDependencyDialogue.tsx
Outdated
Show resolved
Hide resolved
| import { Add } from '@mui/icons-material'; | ||
| import { TooltipLink } from 'component/common/TooltipLink/TooltipLink'; | ||
| import { AddDependencyDialogue } from 'component/feature/Dependencies/AddDependencyDialogue'; | ||
| import { useUiFlag } from 'hooks/useUiFlag'; |
There was a problem hiding this comment.
Unused?
Suggested change
| import { useUiFlag } from 'hooks/useUiFlag'; |
…gue.tsx Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
I have a parent UI:
I have some children UI:
Important files
Discussion points