Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: bubble promise instead of return await #4906

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

nunogois
Copy link
Member

@nunogois nunogois commented Oct 2, 2023

Tiny refactor that bubbles promises instead of using return await. Should be more consistent with the rest of the changes in #4903

@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2023 0:46am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2023 0:46am

Copy link
Contributor

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fair.

@nunogois nunogois merged commit 280e21f into main Oct 2, 2023
16 of 17 checks passed
@nunogois nunogois deleted the refactor-return-promise branch October 2, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants