feat: update dependency permission #4910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kwasniew
commented
Oct 2, 2023
| @@ -30,14 +32,16 @@ export const DependencyRow: FC<{ feature: IFeatureToggle }> = ({ feature }) => { | |||
| <FlexRow> | |||
| <StyledDetail> | |||
| <StyledLabel>Dependency:</StyledLabel> | |||
| <Button | |||
| startIcon={<Add />} | |||
There was a problem hiding this comment.
startIcon was breaking permission button disabled state
ivarconr
reviewed
Oct 2, 2023
| @@ -1,6 +1,7 @@ | |||
| export const ADMIN = 'ADMIN'; | |||
| export const CREATE_FEATURE = 'CREATE_FEATURE'; | |||
| export const UPDATE_FEATURE = 'UPDATE_FEATURE'; | |||
| export const UPDATE_DEPENDENCY = 'UPDATE_DEPENDENCY'; | |||
There was a problem hiding this comment.
can we call it UPDATE_FEATURE_DEPENDENCY?
There was a problem hiding this comment.
sure, updating across all files to keep it consistent.
Comment on lines
+5
to
+6
| SELECT assign_unleash_permission_to_role('UPDATE_FEATURE_DEPENDENCY', 'Member'); | ||
| SELECT assign_unleash_permission_to_role('UPDATE_FEATURE_DEPENDENCY', 'Owner'); |
There was a problem hiding this comment.
Cool, I didn't know you could do this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Add without permission
Add with permission (had to remove plus icon since it breaks the without permission state with lock - only one icon is possible)
Edit/delete without permission:
Edit/delete with permission:
Important files
Discussion points