Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: separate project and project enterprise settings forms #4911

Merged
merged 12 commits into from
Oct 4, 2023

Conversation

andreas-unleash
Copy link
Contributor

Separates ProjectForm and ProjectEnterpriseSettings forms

Signed-off-by: andreas-unleash <andreas@getunleash.ai>
@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 6:53am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2023 6:53am

Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Copy link
Member

@Tymek Tymek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

"Delete Project" button should probably be red, right?

Signed-off-by: andreas-unleash <andreas@getunleash.ai>
andreas-unleash and others added 2 commits October 4, 2023 09:36
…gsForm/CollaborationModeTooltip.tsx

Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
…gsForm/CollaborationModeTooltip.tsx

Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
@andreas-unleash
Copy link
Contributor Author

re- red button - it wasn't before

Signed-off-by: andreas-unleash <andreas@getunleash.ai>
@andreas-unleash
Copy link
Contributor Author

Ignoring the overview.spec.ts tests - verified everything works

@andreas-unleash andreas-unleash merged commit c1f8929 into main Oct 4, 2023
14 of 15 checks passed
@andreas-unleash andreas-unleash deleted the feat/modify-project-creation branch October 4, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants