Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revamp transactional impl #4916

Merged
merged 4 commits into from
Oct 4, 2023
Merged

chore: revamp transactional impl #4916

merged 4 commits into from
Oct 4, 2023

Conversation

gastonfournier
Copy link
Contributor

About the changes

This transactional implementation decorates a service with a transactional method that removes the need to start transactions in the method using the service.

This is a gradual rollout with a feature toggle, just because transactions are not easy.

@vercel
Copy link

vercel bot commented Oct 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2023 1:08pm
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2023 1:08pm

Copy link
Contributor

@kwasniew kwasniew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea. Let's try this.

@gastonfournier gastonfournier merged commit 0da48cc into main Oct 4, 2023
8 checks passed
@gastonfournier gastonfournier deleted the transactional-revamp branch October 4, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants