Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fail when format or lint is incorrect #4956

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Conversation

gastonfournier
Copy link
Contributor

About the changes

Format check was not throwing a failure when checking: https://github.com/Unleash/unleash/actions/runs/6419038883/job/17428046648#step:6:10

@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 8:46am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2023 8:46am

@gastonfournier gastonfournier changed the title Fail when format or lint is incorrect fix: Fail when format or lint is incorrect Oct 6, 2023
Copy link
Contributor

@FredrikOseberg FredrikOseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gastonfournier gastonfournier merged commit 60a07ca into main Oct 6, 2023
14 checks passed
@gastonfournier gastonfournier deleted the biome-check branch October 6, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants