feat: feature changes counted in new table #4958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
chriswk
force-pushed
the
feat/featureUsageStats
branch
2 times, most recently
from
3443abf
to
72467ad
Compare
chriswk
commented
Oct 9, 2023
gastonfournier
approved these changes
Oct 9, 2023
| enterprise: data.versions.enterprise, | ||
| }; | ||
| this.isLatest = data.latest; | ||
| if (this.versionCheckUrl) { |
There was a problem hiding this comment.
I think this change is unrelated but it's worth having it independently of this PR
yes, this looks spot on! We might peek at environment type in the future when taking out the counters, but that can be improved later. |
ivarconr
reviewed
Oct 9, 2023
| "SUM(CASE WHEN day > NOW() - INTERVAL '90 days' THEN updates END)", | ||
| ), | ||
| }) | ||
| .from('stat_environment_updates'); |
There was a problem hiding this comment.
I would expect a where clause here, to only pick production envs
There was a problem hiding this comment.
Totally agree. thanks for the reminder
There was a problem hiding this comment.
I also updated it to look at the environment type and sum across all environments of type 'production'.
…vironmnts of type production
chriswk
force-pushed
the
feat/featureUsageStats
branch
from
d7ba56e
to
f04b3c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of more telemetry on the usage of Unleash.
This PR adds a new
stat_prefixed table as well as a trigger on the events table trigger on each insert to increment a counter per environment per day.The trigger will trigger on every insert into the events base, but will filter and only increment the counter for events that actually have the environment set. (there are events, like user-created, that does not relate to a specific environment).
Bit wary on this, but since we truncate down to row per (day, environment) combo, finding conflict and incrementing shouldn't take too long here.
@ivarconr was it something like this you were considering?