Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename validate step #4969

Merged
merged 1 commit into from
Oct 9, 2023
Merged

chore: Rename validate step #4969

merged 1 commit into from
Oct 9, 2023

Conversation

gastonfournier
Copy link
Contributor

This is to bypass branch protection rules

@gastonfournier gastonfournier self-assigned this Oct 9, 2023
@vercel
Copy link

vercel bot commented Oct 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2023 11:01am
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2023 11:01am

@thomasheartman
Copy link
Contributor

So for clarity (and as a little summary):

Gaston and I just spent a little time looking at this, and it appears that all jobs with a name that matches the name of a required build step must pass before a PR gets merged.

For that reason, renaming the docs' validate step to build (18.x) makes the step required, which means doc builds now need to pass before being merged (assuming there are doc changes). This should fix issues such as renovate bot merging stuff that breaks the docs going forward.

As a potential future improvement here, we might want to change the name of the required step to be just "build", so that it's more generic.

Doing this would require us to change the build matrix such that the name of the build step is not build (18.x) but instead just build.

@gastonfournier gastonfournier merged commit 7f61438 into main Oct 9, 2023
10 checks passed
@gastonfournier gastonfournier deleted the rename-validate-docs branch October 9, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants