Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: visualize dependencies managment in change requests #4978

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Oct 10, 2023

About the changes

Screenshot 2023-10-10 at 09 46 20

Not adding new tests since the new code is mostly declarative with no UI logic

Important files

Discussion points

@vercel
Copy link

vercel bot commented Oct 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 8:09am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2023 8:09am

@@ -150,7 +161,9 @@ export type IFeatureChange =
| IChangeRequestEnabled
| IChangeRequestPatchVariant
| IChangeRequestReorderStrategy
| IChangeRequestArchiveFeature;
| IChangeRequestArchiveFeature
| IChangeRequestAddDependency
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally I'd like those to come from openapi. I'll try to use openapi/orval types in another PR.

Copy link
Contributor

@FredrikOseberg FredrikOseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwasniew kwasniew merged commit af50fc2 into main Oct 10, 2023
9 of 14 checks passed
@kwasniew kwasniew deleted the visualize-dependencies-change-request branch October 10, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants